fix panic in the stored algorithm #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folkertdev
force-pushed
the
window-copy-uninitialized
branch
from
084ec8c
to
486ed98
Compare
Codecov ReportAttention: Patch coverage is
|
folkertdev
force-pushed
the
window-copy-uninitialized
branch
from
486ed98
to
53f4193
Compare
the logic attempted to copy uninitialized bytes. A panic prevented this from happening, and this commit fixes that panic by only copying the initialized section
folkertdev
force-pushed
the
window-copy-uninitialized
branch
from
53f4193
to
6f385f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #218
the logic attempted to copy uninitialized bytes. A panic prevented this from happening, and this commit fixes that panic by only copying the initialized section.
In the future we might, in rust, be able to just come up with a better mechanism around the uninitialized bytes in that window. For now this works fine, I don't think the performance is relevant here.
cc @inahga